Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raster with luminance in webgl1 #2490

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: raster with luminance in webgl1 #2490

merged 1 commit into from
May 21, 2024

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented May 21, 2024

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 工作流程
  • 版本更新
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

WebGL1 下需要使用 Format.F32_LUMINANCE

/**
 * WebGL1 allow the combination of gl.LUMINANCE & gl.FLOAT with OES_texture_float
 */
format: queryVerdorInfo() === 'WebGL1' ? gl.LUMINANCE : gl.RED,
type: gl.FLOAT,

但其实这种组合是不符合规范的:
#2128 (comment)

📝 更新日志

语言 更新描述
🇺🇸 英文
🇨🇳 中文

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@xiaoiver xiaoiver requested a review from lvisei May 21, 2024 11:42
@xiaoiver xiaoiver self-assigned this May 21, 2024
@lvisei lvisei merged commit a092a33 into master May 21, 2024
12 of 13 checks passed
@lvisei lvisei deleted the fix-raster branch May 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants