Upgrade to 2.10 and Fix for "dispute" field in Charge #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
only 28/36 tests pass for me in this branch. most errors were "Did not find value which can be converted into int" |
|
@TheRyanBurke - in case it helps, I did have all the tests working in this fork: https://github.com/d6y/stripe-scala That also includes a fix for he dispute field. |
|
@d6y this got me up to 29/36 and is also targeted for scala 2.9.2 |
|
This should probably be updated to build against 2.10.3 now. |
|
Are you guys merging this in and rolling another public release anytime soon? Please replace with: https://oss.sonatype.org/content/groups/scala-tools/ Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit that contains the upgrade to Scala 2.10 and also fixes a bug in Charge whereas "dispute: Option[Boolean]" was "disputed: Boolean" (see https://stripe.com/docs/api#create_charge).