Ediorial workflow creates unreachable changes

[alexdryden]

Issue
We are using the editorial workflow in a publication for the first time and came across a behavior where an edit produces two edits over the same target text, and only one of them is visible to the author. As a result, the author can not push the page to a clean state without using the "accept all" or "reject all" buttons.

Details
The problem emerged when the author had produced a scalar link that they had made bold with the WYSIWYG and with an extra space as part of the (bold) anchor text. Then the editor deleted the extra space. That deletion shows up in the Edit Review panel as a two edits, a delete of the space and an insert of nothing:

First the deletion:

<span data-diff="chunk" id="chunk_1" data-original-title="" title="">
    <span data-diff="del"> </span>
    <span data-diff="placeholder"></span>
</span>

And then:

<span data-diff="chunk" id="chunk_2" data-original-title="" title="">
    <span data-diff="placeholder"></span>
    <span data-diff="ins"></span>
</span>

The insert however is a 0 x 0 span, so it isn't visible or clickable. Here are some screen shots to illustrate:

Deletion of space

Insertion of nothing

Steps to reproduce

1. Make a new page as an author with some links that follow this basic pattern:

<strong>
    <a href="https://<your-scalar-instal>/<book-name>/page">Scalar Link Bold </a>
</strong>: Some Content 

2. Enable Editorial Workflow and push the page to Edit stage
3. As editor, delete the extra space in the link
4. Push to Edit Review stage
5. As author, resolve all of the edits you see
6. Expected behavior: author can then save and move to clean state
7. Error: save and move to clean state button remains disabled

Environment
Scalar v 2.5.17

[eloyer]

Thanks for the detailed report. So far I've been unable to duplicate the issue under Scalar 2.6 in either Chrome or Safari -- you may want to try updating and see if that resolves it.

[alexdryden]

Thanks for testing it out @eloyer. Yeah, I was having a really hard time getting it to reproduce as well. I'll give it a shot with 2.6.