Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: extends Turbine fanout experiment to wider fanout values (backport of #2373) #2450

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 5, 2024

Problem

Based on previous Turbine fanout experiment, larger fanouts are more effective in propagating shreds and reducing repairs: https://discord.com/channels/428295358100013066/478692221441409024/1265782094211321897

However the optimal fanout value cannot be inferred from the experiment.

Summary of Changes

In order to identify optimal fanout value, this commit extends the experiment with wider fanout values.


This is an automatic backport of pull request #2373 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 5, 2024 22:57
@mergify mergify bot added the conflicts label Aug 5, 2024
Copy link
Author

mergify bot commented Aug 5, 2024

Cherry-pick of 57144b0 has failed:

On branch mergify/bp/v2.0/pr-2373
Your branch is up to date with 'origin/v2.0'.

You are currently cherry-picking commit 57144b0cea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   turbine/src/cluster_nodes.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdk/src/feature_set.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@behzadnouri
Copy link

This is a slight and trivial modification of the experiment currently running on mainnet.
Ideally I would like to get this out asap so that we can settle the optimal turbine fanout before things get more complicated and harder to interpret (e.g. multiple clients, etc).

bw-solana
bw-solana previously approved these changes Aug 7, 2024
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AshwinSekar
AshwinSekar previously approved these changes Aug 7, 2024
@behzadnouri behzadnouri added the automerge automerge Merge this Pull Request automatically once CI passes label Aug 14, 2024
Based on previous Turbine fanout experiment, wider fanouts are more
effective in propagating shreds and reducing repairs:
https://discord.com/channels/428295358100013066/478692221441409024/1265782094211321897

In order to identify optimal fanout value, this commit extends the
experiment with wider fanout values.

(cherry picked from commit 57144b0)
@behzadnouri behzadnouri dismissed stale reviews from AshwinSekar and bw-solana via 74af86e September 4, 2024 20:33
@behzadnouri behzadnouri force-pushed the mergify/bp/v2.0/pr-2373 branch from b4705cd to 74af86e Compare September 4, 2024 20:33
@anza-team anza-team removed the automerge automerge Merge this Pull Request automatically once CI passes label Sep 4, 2024
@anza-team
Copy link
Collaborator

😱 New commits were pushed while the automerge label was present.

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behzadnouri behzadnouri added the automerge automerge Merge this Pull Request automatically once CI passes label Sep 5, 2024
@mergify mergify bot merged commit 1b4dfb3 into v2.0 Sep 10, 2024
41 checks passed
@mergify mergify bot deleted the mergify/bp/v2.0/pr-2373 branch September 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants