-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0: extends Turbine fanout experiment to wider fanout values (backport of #2373) #2450
Conversation
Cherry-pick of 57144b0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This is a slight and trivial modification of the experiment currently running on mainnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on previous Turbine fanout experiment, wider fanouts are more effective in propagating shreds and reducing repairs: https://discord.com/channels/428295358100013066/478692221441409024/1265782094211321897 In order to identify optimal fanout value, this commit extends the experiment with wider fanout values. (cherry picked from commit 57144b0)
74af86e
b4705cd
to
74af86e
Compare
😱 New commits were pushed while the automerge label was present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
Based on previous Turbine fanout experiment, larger fanouts are more effective in propagating shreds and reducing repairs: https://discord.com/channels/428295358100013066/478692221441409024/1265782094211321897
However the optimal fanout value cannot be inferred from the experiment.
Summary of Changes
In order to identify optimal fanout value, this commit extends the experiment with wider fanout values.
This is an automatic backport of pull request #2373 done by [Mergify](https://mergify.com).