Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

[PR commands] check-lint #357

Open
yihau opened this issue Sep 11, 2023 · 3 comments
Open

[PR commands] check-lint #357

yihau opened this issue Sep 11, 2023 · 3 comments
Labels
ci-cd Related to ci, cd

Comments

@yihau
Copy link
Member

yihau commented Sep 11, 2023

@check-lint: run the linter (clippy + fmt).

@yihau yihau added enhancement New feature or request ci-cd Related to ci, cd and removed enhancement New feature or request labels Sep 11, 2023
@yihau
Copy link
Member Author

yihau commented Sep 11, 2023

we have this one atm
https://github.com/solana-labs/move/blob/16ed36ab8d0815dd25372107765619078306109f/.github/workflows/llvm-ci-pre-land.yml#L42-L65

and it will be triggered either

  • create a PR
  • push new code

do we still need this command and when do you use it?

@dmakarov
Copy link

I’m not sure about commands in general. I don’t see myself ever needing to use them. However the lint check I absolutely want to see run and pass without errors before anything is merged to GH solana-labs/move repository. I would also second making this check ‘required’ in GH repository settings, so that merging is blocked when this check hasn’t passed.

@ksolana
Copy link
Collaborator

ksolana commented Oct 21, 2023

let's implement this as it also sets background work for future commands to build/run specific targets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-cd Related to ci, cd
Projects
None yet
Development

No branches or pull requests

3 participants