Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page, Add multiple fields, Cannot select fields #610

Open
horstoeko opened this issue Sep 3, 2024 · 12 comments
Open

Page, Add multiple fields, Cannot select fields #610

horstoeko opened this issue Sep 3, 2024 · 12 comments

Comments

@horstoeko
Copy link

horstoeko commented Sep 3, 2024

Hi;

First of all, thank you very much for this excellent extension, which I use almost every day.

Now to my problem: Recently, it is no longer possible to use the “Add multiple fields” action (page, etc.). The fields can no longer be selected. Shortly after selecting a field, the selection tick disappears again immediately.

image

VSCode

Version: 1.92.2 (system setup)
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Datum: 2024-08-14T17:29:30.058Z (Vor 2 Woche(n))
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
Betriebssystem: Windows_NT x64 10.0.19045

AZ AL DevTools

Name: AZ AL Dev Tools/AL Code Outline
ID: andrzejzwierzchowski.al-code-outline
Beschreibung: AZ AL Development Tools: AL code outline, object browser, object creators
Version: 14.0.956192
Herausgeber: Andrzej Zwierzchowski

I would be delighted if you would look into the matter.

Many thanks and best regards

@NKarolak
Copy link

NKarolak commented Sep 9, 2024

See also #603
For me on v13.71.0 and VS Code 1.93, there even is nothing to select (neither on typing something into the search box):
image

I am using namespaces - could that be the cause?

@horstoeko
Copy link
Author

Hi @anzwdev,
Hi @NKarolak,

today there was an update of VSCode and this extension. Now it seems to work again:

VSCode

Version: 1.93.0 (system setup)
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
Datum: 2024-09-04T13:02:38.431Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
Betriebssystem: Windows_NT x64 10.0.19045

AZ AL DevTools

Name: AZ AL Dev Tools/AL Code Outline
ID: andrzejzwierzchowski.al-code-outline
Beschreibung: AZ AL Development Tools: AL code outline, object browser, object creators
Version: 14.71.1114061
Herausgeber: Andrzej Zwierzchowski
Link zum Visual Studio Marketplace: https://marketplace.visualstudio.com/items?itemName=andrzejzwierzchowski.al-code-outline

@NKarolak
Copy link

NKarolak commented Sep 9, 2024

It is not working for me. I was already on VS Code 1.93, but I am not using the pre-release version of the extension.

@anzwdev
Copy link
Owner

anzwdev commented Sep 9, 2024

There was a problem with fields selection after some changes made to VS Code APIs. I've fixed it in stable version some time ago, but pre-release version was left with old code. I've released a new pre-release version yesterday, which should fix selection problem, but empty list is another issue, which I am going to check as soon as possible.

@erikrijn
Copy link

There was a problem with fields selection after some changes made to VS Code APIs. I've fixed it in stable version some time ago, but pre-release version was left with old code. I've released a new pre-release version yesterday, which should fix selection problem, but empty list is another issue, which I am going to check as soon as possible.

Just checked in both stable and pre-release but the field selection still doesn't even show for me.
Not emply, just not at all.

@anzwdev
Copy link
Owner

anzwdev commented Sep 16, 2024

Hi @erikrijn

Which version of Microsoft AL extension are you using?

@anzwdev
Copy link
Owner

anzwdev commented Sep 24, 2024

I've released a new version of the extension with some changes around namespaces and symbols processing yesterday. Could you check if it is still broken in your VS Code?

@NKarolak
Copy link

See also #603 For me on v13.71.0 and VS Code 1.93, there even is nothing to select (neither on typing something into the search box): image

I am using namespaces - could that be the cause?

Unfortunately, my issue is still not fixed in v13.72.0 (on VS Code 1.93.1). I am using namespaces. In repos without namespaces, it works.

@anzwdev
Copy link
Owner

anzwdev commented Sep 25, 2024

Is there anything in the error log when you run "Open AZ AL Dev Tools log file" command?

@NKarolak
Copy link

There is one repeating error indeed, however not at the exact moment I try to select table fields:

2024-09-26 08:16:19.905 [ERROR] Error: Attempted to read past the end of the stream.
   at StreamJsonRpc.PipeMessageHandler.ReadAtLeastAsync(Int32 requiredBytes, Boolean allowEmpty, CancellationToken cancellationToken)
   at StreamJsonRpc.PipeMessageHandler.DeserializeMessageAsync(Int32 contentLength, Encoding specificEncoding, Encoding defaultEncoding, CancellationToken cancellationToken)
   at StreamJsonRpc.HeaderDelimitedMessageHandler.ReadCoreAsync(CancellationToken cancellationToken)
   at StreamJsonRpc.MessageHandlerBase.ReadAsync(CancellationToken cancellationToken)
   at StreamJsonRpc.JsonRpc.ReadAndHandleRequestsAsync()
   at AnZwDev.ALTools.Server.LanguageServerHost.RunAsync() in D:\a\al-code-outline\al-code-outline\language-server\Shared.AnZwDev.ALTools.Server\LanguageServerHost.cs:line 142

@anzwdev
Copy link
Owner

anzwdev commented Oct 6, 2024

Hi.

I just want to add some update here.

The error above is not related to this issue, it is triggered when Visual Studio is closed.

I am still working on a bigger redesign of internal code parsing functionality, which I hope will solve a few problems including this one.

@NKarolak
Copy link

NKarolak commented Oct 8, 2024

@anzwdev I've just experimented within my repository. To make "Add multiple fields" work again on a certain page, the only thing I need to change is remove all usings. It is even not necessary to replace them with a full qualification (unless you want to compile, of course). Just remove the usings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants