Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning for RDI in Beam coordinates #722

Open
4 tasks
ocehugo opened this issue Dec 14, 2020 · 0 comments
Open
4 tasks

add warning for RDI in Beam coordinates #722

ocehugo opened this issue Dec 14, 2020 · 0 comments
Labels
Type:bug Something is missing or wrong Type:doc documentation related Type:enhancement General enhancements
Milestone

Comments

@ocehugo
Copy link
Contributor

ocehugo commented Dec 14, 2020

Problem reported by Shawn Meredyk.

There is no clue to the user, within the toolbox app, that we only accept RDI adcp in ENU coordinates. Files in Beam coordinates may be silently processed without any warning to the user and may lead to the thinking the data was bin mapped when it wasn't.

The problem lies that workhorseParser forces all variables to be associated with HEIGHT_ABOVE_SENSOR, without verification. The comment may also be misleading without proper verification of the coordinates. Although the current behaviour is consistent with the wiki (the parser assume RDI is coming in ENU), we may need to block non-ENU coordinates to avoid confusion.

Requirements:

  • Check storage of ENU/BEAM metadata from instrument.
  • Handle/Avoid non-ENU coordinates.
  • Create correct warnings.
  • evaluate this in face of new code in 675 rebase #683
@ocehugo ocehugo added this to the Q2 20/21 milestone Feb 9, 2021
@ocehugo ocehugo added Type:bug Something is missing or wrong Type:doc documentation related Type:enhancement General enhancements labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:bug Something is missing or wrong Type:doc documentation related Type:enhancement General enhancements
Projects
None yet
Development

No branches or pull requests

1 participant