Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert sizing seems to be broken for ingest #1343

Open
LizziOh opened this issue Mar 11, 2024 · 1 comment
Open

Invert sizing seems to be broken for ingest #1343

LizziOh opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LizziOh
Copy link
Collaborator

LizziOh commented Mar 11, 2024

https://nrmn.aodn.org.au/data/job/498/edit

I'm trying to ingest data from this file and the validation mechanism is throwing warnings for 700cm Jasus edwardsii weven though Invert sizing is valid for the ingest job and in the IsInvertSized column.

image

I have recently ingested ATRC data and did not notice this issue

I very much need this rectified before ingest. The problem seems to be the validations when outside the l5/L95 are reading the non-invert sizes (fish sizes). But we need to know that on ingest these are not recorded under the fish sizes (ie. is it just the display of the validation warning OR an ingest problem). Is it possible to confirm this ASAP as it another thing holding up data ingest?

@utas-raymondng @bpasquer @atcooper1

@LizziOh LizziOh added the bug Something isn't working label Mar 11, 2024
@bpasquer
Copy link
Contributor

@LizziOh
I've reproduced you issue and after some investigation these are my findings:

  • all errors are correctly reported (ie, they are outside the L5/95 ) but the message translates the indicated size into Fish units in the majority of cases . Unfortunately- (or fortunately) errors are also reported in the correct unit (see the screenshot with the 20cm Jasus).
    Screenshot from 2024-03-15 16-21-21
  • data are recorded in the database in the correct size units

In conclusion the issue seems to be with the unit mapping in the validation message.
However, the inconsistency in behavior suggest there are other things at play here , but I have been unable to fin any clear patterns yet.
But importantly, the data is recorded in the correct size units.

@bpasquer bpasquer added this to the Maintenance - Software milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants