Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MaxLength using latest Fishbase DB version #1372

Open
bpasquer opened this issue Jun 27, 2024 · 4 comments
Open

Update MaxLength using latest Fishbase DB version #1372

bpasquer opened this issue Jun 27, 2024 · 4 comments
Assignees
Labels
data data related issue

Comments

@bpasquer
Copy link
Contributor

  • Identify what fields in fishbase DB contain Maxlength
  • provide list of Maxlength value that will be updated to Toni&Lizzi for review
  • generate script to apply SQL update
@bpasquer bpasquer self-assigned this Jun 27, 2024
@bpasquer
Copy link
Contributor Author

bpasquer commented Oct 1, 2024

@atcooper1 @LizziOh

Here is a comparison of existing NRMN Max Length values with FishBase:
MaxLength_comparison.txt

could you please confirm whether we can apply these changes?

@atcooper1
Copy link
Collaborator

atcooper1 commented Oct 1, 2024

Thanks Bene, I've been working through the list as there are 260 species in which Max size NRMN > Max Size Fishbase. In a lot of these cases I believe Fishbase is not correct (other websites agree with the larger values seen in NRMN), but some are errors in NRMN. Are these better to work through on a case by case basis? Or is it better to bulk change where Fishbase Max Length is equal to or greater than NRMN and leave the larger NRMN values as is (and manually change errors where necessary)?

@bpasquer
Copy link
Contributor Author

bpasquer commented Oct 1, 2024

Maybe a bulk change + case by case basis is the least time consuming approach here

@atcooper1
Copy link
Collaborator

Yes, I think this will work, thanks Bene.

@bpasquer bpasquer added this to the Maintenance - Data milestone Oct 9, 2024
@bpasquer bpasquer added the data data related issue label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data data related issue
Projects
None yet
Development

No branches or pull requests

2 participants