Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behaviour when undo_previous_slices = False #50

Open
mhidas opened this issue Feb 21, 2018 · 1 comment
Open

Wrong behaviour when undo_previous_slices = False #50

mhidas opened this issue Feb 21, 2018 · 1 comment
Labels

Comments

@mhidas
Copy link
Contributor

mhidas commented Feb 21, 2018

If we want the handler to only undo the current slice in the event of a harvest failure, it will only undo the failing harvest itself, but not any previous successful harvesters that ran on the same slice. See #23 (comment)

This is only an issue if we have multiple harvesters AND multiple slices AND only want to unharvest the failing slice. Currently I don't know of such a use case, so I don't think this is high priority.

@mhidas
Copy link
Contributor Author

mhidas commented Feb 21, 2018

Unittests will need updating to test this scenario (#34 (comment))

@mhidas mhidas added the bug label Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant