Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify additional check params separately for each check suite #97

Open
mhidas opened this issue Jun 6, 2018 · 1 comment
Open

Specify additional check params separately for each check suite #97

mhidas opened this issue Jun 6, 2018 · 1 comment

Comments

@mhidas
Copy link
Contributor

mhidas commented Jun 6, 2018

Currently we're only using the check_params config element to specify which check suites (cf / imos) to apply. However, the checker accepts other parameters (see ComplianceChecker.run_checker) that control its behaviour. Some of these (in particular skip_checks and/or criteria) could be used to circumvent some troublesome checks in specific cases (see https://github.com/aodn/internal-discussions/issues/410). However, these parameters may need to be different for CF and IMOS checks.

The current config only allows one set of parameters, e.g.

  "check_params": {
    "checks": [ "cf", "imos:1.4" ],
    "skip_checks": [ "check_dimension_order", "check_convention_globals" ]
  }

Instead, we could have

  "check_params": {
    "cf": {
      "criteria": "normal"
      "skip_checks": [ "check_dimension_order", "check_convention_globals" ]
    },
    "imos:1.4": {
      "criteria": "strict"
    }
  }
@mhidas
Copy link
Contributor Author

mhidas commented Jun 6, 2018

I just realised the skip_checks option expects a list, so I've updated the examples above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant