Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Migrate Dag Run related public endpoint to FastAPI #42701

Closed
12 tasks done
rawwar opened this issue Oct 3, 2024 · 4 comments
Closed
12 tasks done

AIP-84 Migrate Dag Run related public endpoint to FastAPI #42701

rawwar opened this issue Oct 3, 2024 · 4 comments
Assignees
Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API kind:feature Feature Requests
Milestone

Comments

@rawwar
Copy link
Collaborator

rawwar commented Oct 3, 2024

Description

Migrate following endpoint

Use case/motivation

AIP-84

Related issues

Relates to: #42370

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@rawwar rawwar added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Oct 3, 2024
@pierrejeambrun pierrejeambrun added AIP-84 Modern Rest API and removed needs-triage label for new issues that we didn't triage yet labels Oct 3, 2024
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.0 milestone Oct 3, 2024
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Oct 3, 2024
@pierrejeambrun pierrejeambrun changed the title [AIP-84] Migrate Dag Run related public endpoint to FastAPI AIP-84 Migrate Dag Run related public endpoint to FastAPI Oct 3, 2024
@pierrejeambrun pierrejeambrun moved this to In Progress in AIP-84 MODERN REST API Oct 3, 2024
@bbovenzi
Copy link
Contributor

bbovenzi commented Nov 6, 2024

Important to note. For triggering a dagrun, the api_connexion endpoint is missing a lot of the form fields that @jscheffl added to views.py. I think if its best if we consolidate to a single public trigger dag run endpoint in FastAPI.

@jscheffl
Copy link
Contributor

jscheffl commented Nov 6, 2024

Important to note. For triggering a dagrun, the api_connexion endpoint is missing a lot of the form fields that @jscheffl added to views.py. I think if its best if we consolidate to a single public trigger dag run endpoint in FastAPI.

I was always looking at /api/v1/ui/#/DAG/get_dag_details (airflow/api_connexion/endpoints/dag_endpoint.py:get_dag_details()` which contains a dict of all params definitions. I think this should contain all needed information to generate the form views.

Have not checked all default but looking at the fast API I feel like this is the same, have not checked for alle details of complete-ness. But this could be added-in there... I think --> http://localhost:29091/docs#/DAG/get_dag_details (Try it with example_params_ui_tutorial and take a look to params in the response.

And for the triggering after the form is rendered... I assume a "plain dict" just need to be passed as confto the trigger DAG run endpoint like today... so in my view the public API should be sufficient.

FYI @shubhamraj-git

@rawwar
Copy link
Collaborator Author

rawwar commented Nov 27, 2024

Thank you so much for your help @pierrejeambrun , @bugraoz93 , @omkar-foss . I learned a lot while contributing to this endpoint.

@rawwar rawwar closed this as completed Nov 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in AIP-84 MODERN REST API Nov 27, 2024
@pierrejeambrun
Copy link
Member

Thanks @rawwar for you contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API kind:feature Feature Requests
Projects
Development

No branches or pull requests

4 participants