From a3048c5ba8ddd54b0a53bf3b83d69904f3d1f4d2 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sun, 24 Nov 2024 16:57:29 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Bruce Ritchie --- arrow-array/src/builder/generic_bytes_view_builder.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arrow-array/src/builder/generic_bytes_view_builder.rs b/arrow-array/src/builder/generic_bytes_view_builder.rs index 2afe9c6e7df..024bb247405 100644 --- a/arrow-array/src/builder/generic_bytes_view_builder.rs +++ b/arrow-array/src/builder/generic_bytes_view_builder.rs @@ -296,7 +296,7 @@ impl GenericByteViewBuilder { /// - String length exceeds `u32::MAX` #[inline] pub fn append_str(&mut self, value: &str) { - // SAFETY: UTF8 bytes are valid for both string and binaary + // SAFETY: UTF8 bytes are valid for both string and binary unsafe { self.append_bytes(value.as_bytes()) } } @@ -430,7 +430,7 @@ impl GenericByteViewBuilder { buffer_size + in_progress + tracker + views + null } - /// Return a structure that implements `std::fmt::Write` to write stirngs + /// Return a structure that implements `std::fmt::Write` to write strings /// directly to the builder. See example on [`StringViewBuilder`] pub fn formatter(&mut self) -> ByteViewFormatter<'_, T> { ByteViewFormatter::new(self) @@ -677,7 +677,7 @@ where } } -/// When a StringViewWriter is dropped, it writes the the value to the StringViewBuilder +/// When a StringViewWriter is dropped, it writes the value to the StringViewBuilder impl<'a, T> Drop for ByteViewFormatter<'a, T> where T: ByteViewType + ?Sized,