From cb391913372f23c554fc92ed5fd4d20ed41f5cfd Mon Sep 17 00:00:00 2001 From: alexandreyc Date: Wed, 2 Aug 2023 15:05:53 +0200 Subject: [PATCH] Remove old TODO --- arrow-string/src/like.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arrow-string/src/like.rs b/arrow-string/src/like.rs index 9131f7c2f35..448ade49d3a 100644 --- a/arrow-string/src/like.rs +++ b/arrow-string/src/like.rs @@ -246,8 +246,6 @@ macro_rules! datum_function { let left_type = left_array.data_type(); let right_type = right_array.data_type(); - // TODO(alexandreyc): check if PartialEq for DataType is deep or shallow - // i.e. does it check nested subtypes for equality? if left_type != right_type { return Err(ArrowError::ComputeError( "Arrays must have the same data type".to_string(), @@ -913,7 +911,7 @@ mod tests { vec![true, true, true, false, false, true, false, false] ); - // TODO + // OK test_dict_utf8!( test_utf8_array_like_dict, vec!["arrow", "arrow", "arrow", "arrow", "arrow", "arrows", "arrow", "arrow"],