Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datum Based String Kernels #4595

Closed
tustvold opened this issue Jul 30, 2023 · 3 comments · Fixed by #4732
Closed

Datum Based String Kernels #4595

tustvold opened this issue Jul 30, 2023 · 3 comments · Fixed by #4732
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently arrow-string provides methods like

  • contains_dyn
  • contains_utf8_scalar_dyn
  • contains_utf8

We should update it to provide a single contains method taking the Datum abstraction, and deprecate and eventually remove the old APIs.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jul 30, 2023
@alexandreyc
Copy link
Contributor

I'm starting to work on this one 👍

@alexandreyc alexandreyc mentioned this issue Aug 2, 2023
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 24, 2023
@tustvold
Datum based like kernels (apache#4595)
20ea507
@tustvold tustvold mentioned this issue Aug 24, 2023
Merged
tustvold added a commit that referenced this issue Aug 25, 2023
@tustvold
Datum based like kernels (#4595) (#4732)
221f5d2 
* Datum based like kernels (#4595)

* Clippy

* More Clippy

* Review feedback
@tustvold tustvold mentioned this issue Sep 3, 2023
Merged
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4766

@tustvold tustvold added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Sep 18, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow-flight'} from #4732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
2 participants
@alexandreyc @tustvold