-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a mutable builder for Offset
s
#5384
Comments
FWIW I built the offsets directly via |
Maybe we need a PR which makes the trait |
Maybe @kylebarron has some thoughts. I think @tustvold is out for the next week or two so his responses may be delayed) |
The code in geoarrow seems to use to |
As an arg of the function I notice that |
Given OffsetBuffer is used to track offsets within what is effectively a |
As the discussion, |
|
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Part of a discussion in Discord: https://discord.com/channels/885562378132000778/885562378132000781/1205552581422878730
@kylebarron notes that arrow-rs has an immutable
OffsetBuffer
but no mutable builder counterpart.arrow2 had a mutable builder called
Offsets
to help building up the offsets, with helpers like try_push_usize that would enforce the monotonically increasing invariantAs part of his arrow2 -> arrow-rs conversion he vendored that builder in my own code https://github.com/geoarrow/geoarrow-rs/blob/011e77736ac25c55141608c135852c1f5d3198dd/src/array/offset_builder.rs
Describe the solution you'd like
Consider upstreaming
OffsetBuilder
into arrow-rsDescribe alternatives you've considered
We can leave the current situation alone.
Additional context
The text was updated successfully, but these errors were encountered: