Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObjectStore::put_multipart_opts #5435

Closed
tustvold opened this issue Feb 26, 2024 · 1 comment · Fixed by #5652
Closed

Add ObjectStore::put_multipart_opts #5435

tustvold opened this issue Feb 26, 2024 · 1 comment · Fixed by #5652
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Following #4984 added ObjectStore::put_opts taking a PutOptions containing a PutMode. #4999 extended this to support specifying a TagSet. #5334 proposes extending this to support broader categories of metadata.

Whilst PutMode does not apply to put_multipart, as no stores AFAIK support conditional multipart uploads, but TagSet and Attributes would be applicable to multipart uploads, as pointed out by @Xuanwo on #5431 (comment)

Describe the solution you'd like

I would propose introducing a new PutMultipartOptions and a corresponding ObjectStore::put_multipart_opts, with a default implementation of ObjectStore::put_multipart calling through with PutMultipartOptions::default().

Describe alternatives you've considered

We could not do this, however, this would create an unfortunate bifurcation in functionality between multipart and non-multipart uploads.

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Feb 26, 2024
@tustvold tustvold added the development-process Related to development process of arrow-rs label Mar 5, 2024
@tustvold
Copy link
Contributor Author

tustvold commented Mar 5, 2024

Going to proceed with #5458 instead

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
@tustvold tustvold reopened this Mar 18, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 16, 2024
tustvold added a commit that referenced this issue Apr 17, 2024
* Add put_multipart_opts (#5435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant