Formalize the default nested list field name to item
#6785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
gruuya
force-pushed
the
arrow-list-field-item-name
branch
from
692d64e
to
457fce5
Compare
gruuya
force-pushed
the
arrow-list-field-item-name
branch
from
457fce5
to
8b3faa5
Compare
gruuya
changed the title
item
tustvold
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6784.
Rationale for this change
Consolidate the list field naming convention.
What changes are included in this PR?
Add a
Field::LIST_FIELD_DEFAULT_NAMEconstant set toitem, and use it inField::new_list_field.Also replace any calls to
Field::newwith explicit item name to useField::new_list_fieldinstead.Note that this change doesn't touch the convention for Dictionary field names.
Are there any user-facing changes?
None.