Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Dev] Minor edits and slight reorganization of usage_question issue template #45450

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Feb 6, 2025

Rationale for this change

A conversation on Zulip reminded me we have this issue template and, after reviewing, I thought the text could be improved a bit. My main goal was to make it more clear that the user@ list is the place users may want to go with usage questions.

Are these changes tested?

Just by pulling the markdown out and ensuring it renders locally. They do.

Are there any user-facing changes?

Updated issue template.

@github-actions github-actions bot added the awaiting review Awaiting review label Feb 6, 2025
Copy link

@singh1203 singh1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it LGTM.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder whether we want to add a note about better response time on the mailing list. Mainly due to the number of people subscribed vs actively monitoring GitHub but I am not sure how to word it and I am not sure whether it might be too specific and unnecessary.
@amoeba feel free to merge as is

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Feb 7, 2025
@amoeba
Copy link
Member Author

amoeba commented Feb 7, 2025

Thanks for the reviews @singh1203 and @raulcd.

@raulcd I took your suggestion and tweaked the text just a bit in 606cef2. I don't think we want to suggest any one venue has better or worse response times so I made it more about audience size.

@amoeba amoeba merged commit dab09f5 into apache:main Feb 7, 2025
8 of 9 checks passed
@amoeba amoeba removed the awaiting merge Awaiting merge label Feb 7, 2025
@raulcd
Copy link
Member

raulcd commented Feb 7, 2025

Thanks! sounds good to me!

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dab09f5.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants