Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45451: [C#] Integration with Grpc.Net.ClientFactory #45458

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

robcao
Copy link
Contributor

@robcao robcao commented Feb 7, 2025

Rationale for this change

See #45451. This adds out of the box compatibility with the Grpc.Net.ClientFactory, library, which is fairly standardized for users making gRPC requests in .NET web applications.

What changes are included in this PR?

Added a new constructor to FlightClient that accepts a CallInvoker instance.

public FlightClient(CallInvoker callInvoker)

Are these changes tested?

Yes, added a unit test to resolve an instance of the FlightClient using the Grpc.Net.ClientFactory integration and made a request with it.

Are there any user-facing changes?

Yes, a new overload constructor of FlightClient was added.

Copy link

github-actions bot commented Feb 7, 2025

⚠️ GitHub issue #45451 has been automatically assigned in GitHub to PR creator.

Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robcao!

@CurtHagenlocher CurtHagenlocher merged commit d77e559 into apache:main Feb 8, 2025
11 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting review Awaiting review label Feb 8, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d77e559.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants