Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper inner dependency #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set proper inner dependency #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions asterixdb/asterix-doc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<dependencies>
<dependency>
<groupId>org.apache.asterix</groupId>
<artifactId>asterix-lang-sqlpp</artifactId>
<version>0.9.6-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be ${parent.version} ? We always keep this module's versison the same as the parent's. If it's like this it would complicate the version increment process during releases.

Copy link
Member

@parshimers parshimers Jun 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and by "this" I mean <version>, sorry. I thought that comment would get inserted right at line 52.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure how you do that, I've never really worked with Maven before, but do you mean like that?

Suggested change
<version>0.9.6-SNAPSHOT</version>
<version>${parent.version}</version>

</dependency>
</dependencies>
<executions>
<execution>
<id>manual</id>
Expand Down