bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli @pkumar-singh @zymap |
|
https://github.com/apache/bookkeeper/pull/1941/files#r258714042 Here has a discussion about this issue. |
case :
|
|
Temporarily close first, and reopen after improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
bugfix:
when enforceMinNumRacksPerWriteQuorum is false, no need to check racks in quorum
when all bookies is in a rack,when the old bookie node is offline for machine is broken,the ReplicationWorker want call method BookKeeperAdmin.getReplacementBookiesByIndexes, but find minNumRacksPerWriteQuorum(default value is 2) is large than racksInQuorum,but enforceMinNumRacksPerWriteQuorum(default value is false) is not open for checking this rack.
So I think we should charge enforceMinNumRacksPerWriteQuorum is closed,no need to check rack's information
case :
isEnsembleAdheringToPlacementPolicy will return false, then it will be unexpected
Changes
bugfix: when enforceMinNumRacksPerWriteQuorum is false, no need to check racks in quorum