-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gzip extra subfields. #604
Add support for gzip extra subfields. #604
Conversation
8a491d6
to
f44f643
Compare
Hello @ddeschenes-1 Thank you for your PR The build breaks due to not having followed our guidelines here: https://github.com/apache/commons-compress#:~:text=Before%20you%20pushing%20a%20PR%2C%20run%20mvn%20(by%20itself)%2C%20this%20runs%20the%20default%20goal%2C%20which%20contains%20all%20build%20checks.
|
Thanks for the heads up. I'll retry next week, likely with less friction this time. I did use the java convention formatter built in eclipse. I guess it needs tuning. I expect issues with the missing jira too (or '(doc)' commit comment. I'll arrange what I can. |
Hello @ddeschenes-1 As documented, running mvn by itself runs the default goal (as defined in the POM) which includes verify and other goals. If you think our read me file could be better, feel free to create a PR in the commons-build-plugin repository. I'll be happy to review. 😊 |
99bc8a5
to
cc6584c
Compare
cc6584c
to
5e9bcc2
Compare
Hello @ddeschenes-1 Thank you for your updates. While I merged the PR, I had to strip out code that was untested. If you need the APIs, please create a PR that contains the new APIs with unit tests. I also added missing Javadoc comments. In the future, please make sure you provide Javadoc for all new code. TY! |
GzipParameters.setExtra(HeaderExtraField) #604
Definitely need the extra apis for a caller to read the extra! |
Sure, see my previous comment 😀 |
In order to put metadata in a gzip extra fields, this library needed to write and read them.
The extras being tagged with 2 bytes, I choose to make it conveninent by using a 2-chars iso-8859-1 (latin1) string
or if you prefer, using only bytes from 0-255 in ascii (single byte charset). It seems more in line with the spirit of the gzip rfc which uses letters.
A bit of convenience was added to the Extra class to list/add/find subfields.