Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming of rust exposed structs to ease debugging #853

Open
timsaucer opened this issue Sep 3, 2024 · 2 comments · May be fixed by #1059
Open

Change naming of rust exposed structs to ease debugging #853

timsaucer opened this issue Sep 3, 2024 · 2 comments · May be fixed by #1059
Labels
enhancement New feature or request

Comments

@timsaucer
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Right now we have identical names for internal rust representations and python exposed versions. This leads to confusing debug errors like "Cannot convert Expr to Expr". It would be helpful to rename all of the internally exposed objects to something like RawExpr to avoid these confusing errors.

Describe the solution you'd like

Simple renaming - no impact otherwise.

Describe alternatives you've considered

Additional context

@Spaarsh
Copy link

Spaarsh commented Mar 10, 2025

The PR only changes the Expr internal struct and it is still a work in progress. I just need a review on whether this is work in the right direction or not.

@kylebarron
Copy link
Contributor

fwiw I always define my classes exported to Python with a Py prefix on the rust side, and then rename the actual export from within the pyclass macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants