CR.

apache · Oct 5, 2023 · 09a3009 · 09a3009
1 parent 9b86032
commit 09a3009
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -1327,7 +1327,7 @@ impl<'a> Parser<'a> {
                 trim_characters: None,
             })
         } else if self.consume_token(&Token::Comma)
-            && dialect_of!(self is SnowflakeDialect | BigQueryDialect)
+            && dialect_of!(self is SnowflakeDialect | BigQueryDialect | GenericDialect)
         {
             let characters = self.parse_comma_separated(Parser::parse_expr)?;
             self.expect_token(&Token::RParen)?;

diff --git a/tests/sqlparser_common.rs b/tests/sqlparser_common.rs
@@ -5219,7 +5219,7 @@ fn parse_trim() {
     //keep Snowflake/BigQuery TRIM syntax failing
     let all_expected_snowflake = TestedDialects {
         dialects: vec![
-            Box::new(GenericDialect {}),
+            //Box::new(GenericDialect {}),
             Box::new(PostgreSqlDialect {}),
             Box::new(MsSqlDialect {}),
             Box::new(AnsiDialect {}),