From 4b4998e7cabdea884b553ba13f636fea4dcbd797 Mon Sep 17 00:00:00 2001
From: Ayman Elkfrawy <ayman@sigmacomputing.com>
Date: Thu, 21 Nov 2024 12:11:38 -0800
Subject: [PATCH] fix vistior tests and address comment

---
 src/ast/mod.rs     | 4 ----
 src/ast/visitor.rs | 6 +++---
 src/parser/mod.rs  | 2 +-
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/ast/mod.rs b/src/ast/mod.rs
index c1bc37e23..73e846af9 100644
--- a/src/ast/mod.rs
+++ b/src/ast/mod.rs
@@ -166,10 +166,6 @@ impl Ident {
             quote_style: Some(quote),
         }
     }
-
-    pub fn to_object_name_part(&self) -> ObjectNamePart {
-        ObjectNamePart::Identifier(self.clone())
-    }
 }
 
 impl From<&str> for Ident {
diff --git a/src/ast/visitor.rs b/src/ast/visitor.rs
index 418e0a299..99e600b6b 100644
--- a/src/ast/visitor.rs
+++ b/src/ast/visitor.rs
@@ -403,7 +403,7 @@ where
 /// ```
 /// # use sqlparser::parser::Parser;
 /// # use sqlparser::dialect::GenericDialect;
-/// # use sqlparser::ast::{ObjectName, visit_relations_mut};
+/// # use sqlparser::ast::{ObjectName, ObjectNamePart, Ident, visit_relations_mut};
 /// # use core::ops::ControlFlow;
 /// let sql = "SELECT a FROM foo";
 /// let mut statements = Parser::parse_sql(&GenericDialect{}, sql)
@@ -411,7 +411,7 @@ where
 ///
 /// // visit statements, renaming table foo to bar
 /// visit_relations_mut(&mut statements, |table| {
-///   table.0[0].value = table.0[0].value.replace("foo", "bar");
+///   table.0[0] = ObjectNamePart::Identifier(Ident::new("bar"));
 ///   ControlFlow::<()>::Continue(())
 /// });
 ///
@@ -529,7 +529,7 @@ where
 ///   if matches!(expr, Expr::Identifier(col_name) if col_name.value == "x") {
 ///     let old_expr = std::mem::replace(expr, Expr::Value(Value::Null));
 ///     *expr = Expr::Function(Function {
-///           name: ObjectName(vec![Ident::new("f")]),
+///           name: ObjectName::from(vec![Ident::new("f")]),
 ///           args: FunctionArguments::List(FunctionArgumentList {
 ///               duplicate_treatment: None,
 ///               args: vec![FunctionArg::Unnamed(FunctionArgExpr::Expr(old_expr))],
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
index 4e7020594..1dd149466 100644
--- a/src/parser/mod.rs
+++ b/src/parser/mod.rs
@@ -12601,7 +12601,7 @@ impl<'a> Parser<'a> {
                 {
                     parent_name
                         .0
-                        .insert(0, self.parse_identifier(false)?.to_object_name_part());
+                        .insert(0, ObjectNamePart::Identifier(self.parse_identifier(false)?));
                 }
                 (None, Some(parent_name))
             }