Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the visitor for the Option fields #1568

Closed
goldmedal opened this issue Nov 28, 2024 · 2 comments
Closed

Improve the visitor for the Option fields #1568

goldmedal opened this issue Nov 28, 2024 · 2 comments

Comments

@goldmedal
Copy link
Contributor

#1556 enables the visitor to visit the Option field annotated with visit(with = "visit_xxx") in an Expr. I focused on implementing the macro and fixing the functionality of SHOW COLUMNS in DataFusion.
However, other fields also need to be annotated. See @alamb's comment (#1556 (comment)) for details.
@goldmedal goldmedal mentioned this issue Nov 28, 2024
Merged
@git-hulk
Copy link
Member

@alamb @iffyio Can close this issue since it has been done now.

@alamb alamb closed this as completed Dec 11, 2024
@alamb
Copy link
Contributor

alamb commented Dec 11, 2024

Thanks for the callout @git-hulk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alamb @git-hulk @goldmedal