Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verificiation script fails on cargo publish --dry-run when there are changes to derive #1596

Open
alamb opened this issue Dec 12, 2024 · 0 comments

Comments

@alamb
Copy link
Contributor

alamb commented Dec 12, 2024

When you run ./dev/release/verify_release.sh 0.53.0 2 I got the following error:

+ find -iname Cargo.toml
+ xargs grep SNAPSHOT
find: illegal option -- i
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
+ cargo publish --dry-run
    Updating crates.io index
   Packaging sqlparser v0.53.0 (/private/var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.fm9FlzQWEQ/apache-datafusion-sqlparser-rs-0.53.0)
warning: ignoring example `cli` as `examples/cli.rs` is not included in the published package
warning: ignoring example `parse_select` as `examples/parse_select.rs` is not included in the published package
warning: ignoring test `sqlparser_bigquery` as `tests/sqlparser_bigquery.rs` is not included in the published package
warning: ignoring test `sqlparser_clickhouse` as `tests/sqlparser_clickhouse.rs` is not included in the published package
warning: ignoring test `sqlparser_common` as `tests/sqlparser_common.rs` is not included in the published package
warning: ignoring test `sqlparser_custom_dialect` as `tests/sqlparser_custom_dialect.rs` is not included in the published package
warning: ignoring test `sqlparser_databricks` as `tests/sqlparser_databricks.rs` is not included in the published package
warning: ignoring test `sqlparser_duckdb` as `tests/sqlparser_duckdb.rs` is not included in the published package
warning: ignoring test `sqlparser_hive` as `tests/sqlparser_hive.rs` is not included in the published package
warning: ignoring test `sqlparser_mssql` as `tests/sqlparser_mssql.rs` is not included in the published package
warning: ignoring test `sqlparser_mysql` as `tests/sqlparser_mysql.rs` is not included in the published package
warning: ignoring test `sqlparser_postgres` as `tests/sqlparser_postgres.rs` is not included in the published package
warning: ignoring test `sqlparser_redshift` as `tests/sqlparser_redshift.rs` is not included in the published package
warning: ignoring test `sqlparser_regression` as `tests/sqlparser_regression.rs` is not included in the published package
warning: ignoring test `sqlparser_snowflake` as `tests/sqlparser_snowflake.rs` is not included in the published package
warning: ignoring test `sqlparser_sqlite` as `tests/sqlparser_sqlite.rs` is not included in the published package
    Updating crates.io index
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for the requirement `sqlparser_derive = "^0.3.0"`
  candidate versions found which didn't match: 0.2.2, 0.2.1, 0.2.0, ...
  location searched: crates.io index
  required by package `sqlparser v0.53.0 (/private/var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.fm9FlzQWEQ/apache-datafusion-sqlparser-rs-0.53.0)`
+ cleanup
+ '[' no = yes ']'
+ echo 'Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.fm9FlzQWEQ for details.'
Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.fm9FlzQWEQ for details.

I believe the issue is that we also have a new version of sqlparser-derive to publish as well, but since that is not yet published on cargo, testing cargo publish for sqlparser will not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant