Skip to content

Commit

Permalink
Minor: add ticket reference and fmt (#11805)
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb authored Aug 5, 2024
1 parent b4069a6 commit 1d3bdbe
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion datafusion/proto/src/physical_plan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,13 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {

// TODO: approx_percentile_cont and approx_percentile_cont_weight are not supported for UDAF from protobuf yet.
// TODO: `order by` is not supported for UDAF yet
AggregateExprBuilder::new(agg_udf, input_phy_expr).schema(Arc::clone(&physical_schema)).name(name).with_ignore_nulls(agg_node.ignore_nulls).with_distinct(agg_node.distinct).build()
// https://github.com/apache/datafusion/issues/11804
AggregateExprBuilder::new(agg_udf, input_phy_expr)
.schema(Arc::clone(&physical_schema))
.name(name)
.with_ignore_nulls(agg_node.ignore_nulls)
.with_distinct(agg_node.distinct)
.build()
}
}
}).transpose()?.ok_or_else(|| {
Expand Down

0 comments on commit 1d3bdbe

Please sign in to comment.