From 3ad250c562d1ed1ee641b8e13be094cec3eafb8d Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sat, 14 Dec 2024 20:36:49 +0200 Subject: [PATCH] add comment why `descending: false` --- datafusion/functions/src/core/least.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/functions/src/core/least.rs b/datafusion/functions/src/core/least.rs index f17eb0462234..aa207247d050 100644 --- a/datafusion/functions/src/core/least.rs +++ b/datafusion/functions/src/core/least.rs @@ -31,7 +31,7 @@ use std::any::Any; use std::sync::{Arc, OnceLock}; const SORT_OPTIONS: SortOptions = SortOptions { - // We want least first + // Decreasing here as we will use lower than or equal to find the smallest value descending: false, // NULL will be greater than any other value