From 93569ed435a5656c5f72907b951bec1d36b4be32 Mon Sep 17 00:00:00 2001 From: jcsherin Date: Thu, 17 Oct 2024 13:11:11 +0530 Subject: [PATCH] Revert "Disable failing sqllogic tests for handling NULL input" This reverts commit 270a2030637012d549c001e973a0a1bb6b3d4dd0. --- datafusion/sqllogictest/test_files/window.slt | 87 +++++++++---------- 1 file changed, 43 insertions(+), 44 deletions(-) diff --git a/datafusion/sqllogictest/test_files/window.slt b/datafusion/sqllogictest/test_files/window.slt index 17723e606270..9ecd6f8b445b 100644 --- a/datafusion/sqllogictest/test_files/window.slt +++ b/datafusion/sqllogictest/test_files/window.slt @@ -4945,49 +4945,48 @@ DROP TABLE t; ## test handle NULL of lead -# TODO: Port this bug fix: https://github.com/apache/datafusion/pull/12811 -# statement ok -# create table t1(v1 int); -# -# statement ok -# insert into t1 values (1); -# -# query B -# SELECT LEAD(NULL, 0, false) OVER () FROM t1; -# ---- -# NULL -# -# query B -# SELECT LAG(NULL, 0, false) OVER () FROM t1; -# ---- -# NULL -# -# query B -# SELECT LEAD(NULL, 1, false) OVER () FROM t1; -# ---- -# false -# -# query B -# SELECT LAG(NULL, 1, false) OVER () FROM t1; -# ---- -# false -# -# statement ok -# insert into t1 values (2); -# -# query B -# SELECT LEAD(NULL, 1, false) OVER () FROM t1; -# ---- -# NULL -# false -# -# query B -# SELECT LAG(NULL, 1, false) OVER () FROM t1; -# ---- -# false -# NULL -# -# statement ok -# DROP TABLE t1; +statement ok +create table t1(v1 int); + +statement ok +insert into t1 values (1); + +query B +SELECT LEAD(NULL, 0, false) OVER () FROM t1; +---- +NULL + +query B +SELECT LAG(NULL, 0, false) OVER () FROM t1; +---- +NULL + +query B +SELECT LEAD(NULL, 1, false) OVER () FROM t1; +---- +false + +query B +SELECT LAG(NULL, 1, false) OVER () FROM t1; +---- +false + +statement ok +insert into t1 values (2); + +query B +SELECT LEAD(NULL, 1, false) OVER () FROM t1; +---- +NULL +false + +query B +SELECT LAG(NULL, 1, false) OVER () FROM t1; +---- +false +NULL + +statement ok +DROP TABLE t1; ## end test handle NULL of lead \ No newline at end of file