Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Qualified Wildcard in Count #11323

Closed
tshauck opened this issue Jul 7, 2024 · 0 comments · Fixed by #12673
Closed

Support Qualified Wildcard in Count #11323

tshauck opened this issue Jul 7, 2024 · 0 comments · Fixed by #12673
Labels
enhancement New feature or request

Comments

@tshauck
Copy link
Contributor

tshauck commented Jul 7, 2024

Is your feature request related to a problem or challenge?

In working on #11229 I noticed that SELECT COUNT(t1.*) FROM t1 doesn't work and throws a not implemented error.

Error: NotImplemented("Unsupported qualified wildcard argument: Unnamed(QualifiedWildcard(ObjectName([Ident { value: \"t1\", quote_style: None }])))")

If it is to be implemented it may make sense to wait until after #11229 is merged.

Describe the solution you'd like

Fill out this match arm:

_ => not_impl_err!("Unsupported qualified wildcard argument: {sql:?}"),

Describe alternatives you've considered

No response

Additional context

This query is supported by postgres and duckdb as a cursory check, so might be nice to support it, though it's not used super often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant