Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to_json function on struct type #11441

Closed
dharanad opened this issue Jul 12, 2024 · 2 comments
Closed

Support to_json function on struct type #11441

dharanad opened this issue Jul 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dharanad
Copy link
Contributor

Is your feature request related to a problem or challenge?

This request is to support to_json in comet apache/datafusion-comet#631. Rather implementing this in comet, i think we should have this function over here and let comet rely on datafusion. Since we also support struct now, this would be a good to have feature.

to_json function Converts a column containing a structs to JSON string. We can incrementally support this functions for other types.

Describe the solution you'd like

TBD

Describe alternatives you've considered

No response

Additional context

No response

@dharanad dharanad added the enhancement New feature or request label Jul 12, 2024
@wjones127
Copy link
Member

I wonder if this would belong in this repo instead: https://github.com/datafusion-contrib/datafusion-functions-json

@dharanad
Copy link
Contributor Author

dharanad commented Jul 16, 2024

I wonder if this would belong in this repo instead: https://github.com/datafusion-contrib/datafusion-functions-json

I agree datafusion-functions-json is the place for this function. Will re open this issue over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants