Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate documentation for all datetime functions from scalar_functions.md to code #12859

Closed
Tracked by #12740
alamb opened this issue Oct 10, 2024 · 5 comments · Fixed by #12966
Closed
Tracked by #12740

Migrate documentation for all datetime functions from scalar_functions.md to code #12859

alamb opened this issue Oct 10, 2024 · 5 comments · Fixed by #12966
Assignees
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Oct 10, 2024

Is your feature request related to a problem or challenge?

As part of #12740 this ticket is to migrate all the existing documentation for the above named functions from the static documentation to code and to remove them from the static file.

Here is the current static content:

Need Functions:
(see source)

Describe the solution you'd like

One (or more) PRs that

  1. port the documentation for the above named functions from the static docs to code
  2. Bonus points: add sql examples should be added for all functions
  3. Remove the documentation from the static docs
  4. Run ./dev/update_function_docs.sh to update the dynamic documentation

Here are some example PRs of doing this:

  1. Crypto Function Migration #12840 from @jonathanc-n
  2. Migrate documentation for all string functions from scalar_functions.md to code  #12775 from @Omega359
  3. Port / Add Documentation for VarianceSample and VariancePopulation #12742

Describe alternatives you've considered

No response

Additional context

No response

@alamb
Copy link
Contributor Author

alamb commented Oct 10, 2024

I think this is a good first issue as the pattern is clear and it would be a good way to learn how the process works

@alamb alamb added the good first issue Good for newcomers label Oct 10, 2024
@jatin510
Copy link
Contributor

take

@alamb
Copy link
Contributor Author

alamb commented Oct 11, 2024

Thanks @jatin510 🙏

BTW @jonathanc-n notes on #12740 (comment)

@alamb I think it should be mentioned here that ./dev/update_function_docs.sh should be ran, as it wasn't immediately obvious, and when I did my first migration I took a bit of time to find it.

@alamb
Copy link
Contributor Author

alamb commented Oct 15, 2024

Just checking in on how this is going @jatin510 -- if you don't have time, perhaps I can unassign you so others could work on it

@jatin510
Copy link
Contributor

I will create a PR by tomorrow @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants