Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Cleaned physical-plan Comments #13055

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Going through learning codebase, cleaned some comments/code

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Oct 22, 2024
datafusion/physical-plan/src/execution_plan.rs Outdated Show resolved Hide resolved
datafusion/physical-plan/src/stream.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think the capitalization changes are necessary, but the other corrections are much appreciated.

@alamb alamb merged commit d3920f3 into apache:main Oct 22, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented Oct 22, 2024

🚀 -- thanks @jonathanc-n and @findepi and @timsaucer for the reviews

@jonathanc-n jonathanc-n deleted the small-fix-physical-plan- branch November 17, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants