Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate window functions documentation to attribute based #13739

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

zjregee
Copy link
Member

@zjregee zjregee commented Dec 12, 2024

Which issue does this PR close?

Closes #13670.

Rationale for this change

What changes are included in this PR?

As discussed in #13670, this PR will migrate the parts of window function documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zjregee
I think it is good for now, probably later we can figure out how to deal with enum invariants.

I dont see .md file changed which means the transition is good

@alamb
Copy link
Contributor

alamb commented Dec 12, 2024

Thanks @zjregee -- it looks like this PR has some conflicts that need to be resolved prior to merge. Can you merge up from main that so we can merge the PR?

@zjregee
Copy link
Member Author

zjregee commented Dec 13, 2024

@alamb, the conflict has been resolved.

@comphead comphead merged commit 6ac1999 into apache:main Dec 13, 2024
27 checks passed
@zjregee zjregee deleted the migrate-doc-gen branch December 13, 2024 06:13
@alamb
Copy link
Contributor

alamb commented Dec 13, 2024

Thanks @zjregee and @comphead 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc-gen: Migrate windows functions from code based documentation to attribute based
3 participants