Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Examples: regexp.rs into dataframe.rs and sql_query.rs #13938

Closed
Tracked by #11172
alamb opened this issue Dec 29, 2024 · 2 comments
Closed
Tracked by #11172

Consolidate Examples: regexp.rs into dataframe.rs and sql_query.rs #13938

alamb opened this issue Dec 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Dec 29, 2024

Is your feature request related to a problem or challenge?

The large number of small examples in DataFusion leads to multiple problems:

  • Makes it harder to find the relevant examples
  • Unnecessarily large amounts of disk space on a full build (each example binary takes 100+ MB)
  • Larger cargo t time (each binary must be linked / created)

Thus I think the fewer examples we have the

  1. easier it will be to find the relevant examples
  2. faster our dev experience will be

Describe the solution you'd like

I would like to consolidate the common SQL based examples and common dataframe based query examples

Then update the readme page:

Describe alternatives you've considered

No response

Additional context

I think this is a good first issue as the task is straightforward and doesn't require deep understanding of the DataFusion codebase

@alamb alamb added the enhancement New feature or request label Dec 29, 2024
@alamb alamb self-assigned this Dec 29, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 29, 2024

I would like to do this one myself and then I will file tickets for the other similar examples that I think others could work on in parallel

@alamb
Copy link
Contributor Author

alamb commented Dec 29, 2024

After studying regexp.rs I think the content actually should go into the docs for the various regexp functions rather than the examples. 🤔

@alamb alamb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant