-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ClickBench queries to avoid to_timestamp_seconds
#15465
Comments
take |
I think it is because we don't have the analysis to translate the |
|
Another discrepancy I found in the queries is the "EventDate"::INT::DATE" casting. Is this something we could remove as well? Maybe would be good to look at all further that are applied to the queries and undo them if possible (or file issues when the planner fails to plan them). |
|
Is your feature request related to a problem or challenge?
For some reason the DataFusion version of the ClickBench queries use the
to_timestamp_seconds
function:datafusion/benchmarks/queries/clickbench/queries.sql
Line 24 in 46f4024
However that function does timestamp validation and potentially slows down queries and prevents other optimizations (for example what @adriangb is doing in #15301)
I checked and DuckDB simply uses
EventTime
https://github.com/ClickHouse/ClickBench/blob/bdc6e32589c2785a66ccee98904a322c5e5d3f50/duckdb/queries.sql#L24C1-L25C1
As does
ClickHouse
https://github.com/ClickHouse/ClickBench/blob/bdc6e32589c2785a66ccee98904a322c5e5d3f50/clickhouse/queries.sql#L24
Describe the solution you'd like
Ideally the queries would be updated so they do not use to_timestamp_seconds
For example
Describe alternatives you've considered
Additional context
No response
The text was updated successfully, but these errors were encountered: