Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptree crate is old and uses old outdated dependencies #7550

Closed
alamb opened this issue Sep 13, 2023 · 5 comments · Fixed by #7560
Closed

ptree crate is old and uses old outdated dependencies #7550

alamb opened this issue Sep 13, 2023 · 5 comments · Fixed by #7560
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Sep 13, 2023

Describe the bug

ptree was added as a dependency in #7192

However the most recent version of ptree is 2 years old https://crates.io/crates/ptree/versions

And it pulls in older versions of serde and various other dependencies.

To Reproduce

Look at datafusion-cli/Cargo.lock

Expected behavior

I would like to avoid all the old dependencies -- so either by updating ptree somehow or maybe simply by avoiding the dependency

Additional context

No response

@alamb alamb added the bug Something isn't working label Sep 13, 2023
@alamb
Copy link
Contributor Author

alamb commented Sep 13, 2023

@avantgardnerio any thoughts here?

@avantgardnerio
Copy link
Contributor

I only included it as a dev-dependency for ease of reading/asserting tree balancing. Let me see if I can find another equivalent crate, or we can do more ugly asserts.

@avantgardnerio
Copy link
Contributor

how's this:? https://crates.io/crates/termtree

@avantgardnerio
Copy link
Contributor

I checked - it has no dependencies. I'll sub it in shortly...

@alamb
Copy link
Contributor Author

alamb commented Sep 14, 2023

I checked - it has no dependencies

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants