Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of requireTimeCondition in query context #17401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aho135
Copy link
Contributor

@aho135 aho135 commented Oct 22, 2024

Fixes #17434 .

Description

When druid.sql.planner.requireTimeCondition is set to true the datasource preview fails to load because it makes a query without a time filter. This PR adds the ability to override requireTimeCondition in the query context

Added requireTimeCondition in PlannerConfig

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

One alternative is to just add a filter to the query in __time with a long lookback. This isn't reliable though since the retention of the underlying datasource is unknown

Release note


Key changed/added classes in this PR
  • PlannerConfig
  • datasource-preview-pane

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@aho135
Copy link
Contributor Author

aho135 commented Oct 22, 2024

Screenshot 2024-10-22 at 2 16 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasource Preview Breaks when druid.sql.planner.requireTimeCondition=true
1 participant