Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryCountStatsMonitor doesn't track sql query metrics #11652

Open
a2l007 opened this issue Sep 1, 2021 · 3 comments · May be fixed by #17452
Open

QueryCountStatsMonitor doesn't track sql query metrics #11652

a2l007 opened this issue Sep 1, 2021 · 3 comments · May be fixed by #17452
Labels
Area - SQL Feature

Comments

@a2l007
Copy link
Contributor

a2l007 commented Sep 1, 2021 •
edited
Loading

QueryCountStatsMonitor provides the following query metrics

  • query/count
  • query/success/count
  • query/failed/count
  • query/interrupted/count
  • query/timeout/count

It looks like these metrics don't track the sql queries invoked against the druid/v2/sql endpoint.

This could be because the Broker is tied to BrokerQueryResource as the QueryCountStatsProvider implementation and even if SqlResource implements QueryCountStatsProvider, it wouldn't work. Unless the SqlResource was isolated as such for a specific reason, I'd like to check the feasibility of merging SqlResource into QueryResource so that druid/v2/sql can take advantage of the query count stats monitoring within QueryResource.

@jihoonson Any thoughts on this?
@maytasm
Copy link
Contributor

maytasm commented Nov 1, 2024

@a2l007 Did you have a chance to work on this?

@jtuglu-netflix jtuglu-netflix linked a pull request Nov 6, 2024 that will close this issue
Open
10 tasks
@a2l007
Copy link
Contributor Author

a2l007 commented Nov 8, 2024

@maytasm Nope, but looks like there is already a PR out for this!

@maytasm
Copy link
Contributor

maytasm commented Nov 9, 2024

@a2l007 Yep. If you have a few minutes, would appreciate if you can review the PR #17452 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - SQL Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit QueryCountMetrics for SQL Queries jtuglu-netflix/druid
3 participants
@abhishekagarwal87 @a2l007 @maytasm