Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Do some code optimization.[EventMeshCommon] #4763

Open
3 tasks done
scwlkq opened this issue Feb 1, 2024 · 1 comment · May be fixed by #4764
Open
3 tasks done

[Enhancement] Do some code optimization.[EventMeshCommon] #4763

scwlkq opened this issue Feb 1, 2024 · 1 comment · May be fixed by #4764
Labels
enhancement New feature or request Stale

Comments

@scwlkq
Copy link
Contributor

scwlkq commented Feb 1, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

As comment:
I found that the EventMeshCommon class in the original TCP package was referenced by the classes of grpc, HTTP, and other modules. So should I placed this class under the Common module and corrected the reference? This also eliminates the coupling between the modules of the Java SDK.

Now reference:
image

Describe the solution you'd like

Move EventMesh class to common module, and check original references.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@scwlkq scwlkq added the enhancement New feature or request label Feb 1, 2024
@scwlkq scwlkq linked a pull request Feb 1, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4763] Do some code optimization.[EventMeshCommon] scwlkq/eventmesh
1 participant
@scwlkq