Skip to content

Commit d39b8a6

Browse files
authored
[hotfix] Simplify the checkpointStatsSnapshotCacheExpireAfterWrite (#26349)
1 parent 36111ca commit d39b8a6

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,7 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura
114114

115115
final int checkpointHistorySize = configuration.get(WebOptions.CHECKPOINTS_HISTORY_SIZE);
116116
final Duration checkpointStatsSnapshotCacheExpireAfterWrite =
117-
configuration
118-
.getOptional(RestOptions.CACHE_CHECKPOINT_STATISTICS_TIMEOUT)
119-
.orElse(Duration.ofMillis(refreshInterval));
117+
configuration.get(RestOptions.CACHE_CHECKPOINT_STATISTICS_TIMEOUT);
120118
final int checkpointStatsSnapshotCacheSize =
121119
configuration.get(RestOptions.CACHE_CHECKPOINT_STATISTICS_SIZE);
122120

flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/RestHandlerConfigurationTest.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,16 @@ private static void testWebCancelFeatureFlag(boolean webCancelEnabled) {
106106

107107
@Test
108108
void testCheckpointCacheExpireAfterWrite() {
109-
final Duration testDuration = Duration.ofMillis(100L);
110109
final Configuration config = new Configuration();
111-
config.set(RestOptions.CACHE_CHECKPOINT_STATISTICS_TIMEOUT, testDuration);
112-
110+
final Duration defaultDuration = Duration.ofMillis(3000L);
113111
RestHandlerConfiguration restHandlerConfiguration =
114112
RestHandlerConfiguration.fromConfiguration(config);
113+
assertThat(restHandlerConfiguration.getCheckpointCacheExpireAfterWrite())
114+
.isEqualTo(defaultDuration);
115+
116+
final Duration testDuration = Duration.ofMillis(100L);
117+
config.set(RestOptions.CACHE_CHECKPOINT_STATISTICS_TIMEOUT, testDuration);
118+
restHandlerConfiguration = RestHandlerConfiguration.fromConfiguration(config);
115119
assertThat(restHandlerConfiguration.getCheckpointCacheExpireAfterWrite())
116120
.isEqualTo(testDuration);
117121
}

0 commit comments

Comments
 (0)