GUACAMOLE-1846: Check for NULLs before attempting to sync state in join pending handlers. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
requested changes
Sep 30, 2023
|
…in pending handlers.
jmuehlner
force-pushed
the
GUACAMOLE-1846-add-null-checks-in-pending-handler
branch
from
cf6d80b
to
13e22c6
Compare
necouchman
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user promotion thread is started before the client initialization is fully complete, so we should not expect that all client resources will be available when the pending handlers run.
If the resources are uninitialized, the pending handlers can still run successfully because there isn't any state to sync anyway.