IGNITE-24777 Fix reading performance statistics report due to miss-cached strings (#11949)

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution 
we ask you to ensure the following steps have been taken:

### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request. 
- [x] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [x] The pull request body describes changes that have been made. 
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [x] The pull request title is treated as the final commit message. 
The following pattern must be used: `IGNITE-XXXX Change summary` where
`XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments 
(see [the Maintainers
list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [x] The pull request has been checked by the Teamcity Bot and 
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check
PR](https://mtcga.gridgain.com/prs.html))

### Notes
- [How to
Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity
Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)

If you need any help, please email [email protected] or ask anу
advice on http://asf.slack.com _#ignite_ channel.

Author: chesnokoff

modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/FilePerformanceStatisticsReader.java

@@ -60,13 +60,15 @@
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.VERSION;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.cacheOperation;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.cacheRecordSize;
-import static org.apache.ignite.internal.processors.performancestatistics.OperationType.cacheStartRecordSize;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.checkpointRecordSize;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.jobRecordSize;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.pagesWriteThrottleRecordSize;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.queryReadsRecordSize;
-import static org.apache.ignite.internal.processors.performancestatistics.OperationType.queryRecordSize;
-import static org.apache.ignite.internal.processors.performancestatistics.OperationType.taskRecordSize;
+import static org.apache.ignite.internal.processors.performancestatistics.OperationType.readCacheStartRecordSize;
+import static org.apache.ignite.internal.processors.performancestatistics.OperationType.readQueryPropertyRecordSize;
+import static org.apache.ignite.internal.processors.performancestatistics.OperationType.readQueryRecordSize;
+import static org.apache.ignite.internal.processors.performancestatistics.OperationType.readQueryRowsRecordSize;
+import static org.apache.ignite.internal.processors.performancestatistics.OperationType.readTaskRecordSize;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.transactionOperation;
 import static org.apache.ignite.internal.processors.performancestatistics.OperationType.transactionRecordSize;
 
@@ -267,48 +269,21 @@ else if (transactionOperation(opType)) {
             return true;
         }
         else if (opType == QUERY) {
-            if (buf.remaining() < 1)
-                return false;
-
-            boolean cached = buf.get() != 0;
-
-            String text;
-            int hash = 0;
-
-            if (cached) {
-                if (buf.remaining() < 4)
-                    return false;
-
-                hash = buf.getInt();
-
-                text = knownStrs.get(hash);
-
-                if (buf.remaining() < queryRecordSize(0, true) - 1 - 4)
-                    return false;
-            }
-            else {
-                if (buf.remaining() < 4)
-                    return false;
-
-                int textLen = buf.getInt();
-
-                if (buf.remaining() < queryRecordSize(textLen, false) - 1 - 4)
-                    return false;
+            ForwardableString text = readString(buf);
 
-                text = readString(buf, textLen);
-            }
+            if (text == null || buf.remaining() < readQueryRecordSize())
+                return false;
 
             GridCacheQueryType qryType = GridCacheQueryType.fromOrdinal(buf.get());
             long id = buf.getLong();
             long startTime = buf.getLong();
             long duration = buf.getLong();
             boolean success = buf.get() != 0;
 
-            if (text == null)
-                forwardRead(hash);
+            forwardRead(text);
 
             for (PerformanceStatisticsHandler hnd : curHnd)
-                hnd.query(nodeId, qryType, text, id, startTime, duration, success);
+                hnd.query(nodeId, qryType, text.str, id, startTime, duration, success);
 
             return true;
         }
@@ -328,86 +303,64 @@ else if (opType == QUERY_READS) {
             return true;
         }
         else if (opType == QUERY_ROWS) {
-            String action = readCacheableString(buf);
+            ForwardableString action = readString(buf);
 
-            if (action == null || buf.remaining() < 1 + 16 + 8 + 8)
+            if (action == null || buf.remaining() < readQueryRowsRecordSize())
                 return false;
 
             GridCacheQueryType qryType = GridCacheQueryType.fromOrdinal(buf.get());
             UUID uuid = readUuid(buf);
             long id = buf.getLong();
             long rows = buf.getLong();
 
+            forwardRead(action);
+
             for (PerformanceStatisticsHandler hnd : curHnd)
-                hnd.queryRows(nodeId, qryType, uuid, id, action, rows);
+                hnd.queryRows(nodeId, qryType, uuid, id, action.str, rows);
 
             return true;
         }
         else if (opType == QUERY_PROPERTY) {
-            String name = readCacheableString(buf);
+            ForwardableString name = readString(buf);
 
             if (name == null)
                 return false;
 
-            String val = readCacheableString(buf);
+            ForwardableString val = readString(buf);
 
             if (val == null)
                 return false;
 
-            if (buf.remaining() < 1 + 16 + 8)
+            if (buf.remaining() < readQueryPropertyRecordSize())
                 return false;
 
             GridCacheQueryType qryType = GridCacheQueryType.fromOrdinal(buf.get());
             UUID uuid = readUuid(buf);
             long id = buf.getLong();
 
+            forwardRead(name);
+            forwardRead(val);
+
             for (PerformanceStatisticsHandler hnd : curHnd)
-                hnd.queryProperty(nodeId, qryType, uuid, id, name, val);
+                hnd.queryProperty(nodeId, qryType, uuid, id, name.str, val.str);
 
             return true;
         }
         else if (opType == TASK) {
-            if (buf.remaining() < 1)
-                return false;
-
-            boolean cached = buf.get() != 0;
-
-            String taskName;
-            int hash = 0;
-
-            if (cached) {
-                if (buf.remaining() < 4)
-                    return false;
-
-                hash = buf.getInt();
+            ForwardableString taskName = readString(buf);
 
-                taskName = knownStrs.get(hash);
-
-                if (buf.remaining() < taskRecordSize(0, true) - 1 - 4)
-                    return false;
-            }
-            else {
-                if (buf.remaining() < 4)
-                    return false;
-
-                int nameLen = buf.getInt();
-
-                if (buf.remaining() < taskRecordSize(nameLen, false) - 1 - 4)
-                    return false;
-
-                taskName = readString(buf, nameLen);
-            }
+            if (taskName == null || buf.remaining() < readTaskRecordSize())
+                return false;
 
             IgniteUuid sesId = readIgniteUuid(buf);
             long startTime = buf.getLong();
             long duration = buf.getLong();
             int affPartId = buf.getInt();
 
-            if (taskName == null)
-                forwardRead(hash);
+            forwardRead(taskName);
 
             for (PerformanceStatisticsHandler hnd : curHnd)
-                hnd.task(nodeId, sesId, taskName, startTime, duration, affPartId);
+                hnd.task(nodeId, sesId, taskName.str, startTime, duration, affPartId);
 
             return true;
         }
@@ -427,41 +380,17 @@ else if (opType == JOB) {
             return true;
         }
         else if (opType == CACHE_START) {
-            if (buf.remaining() < 1)
-                return false;
-
-            boolean cached = buf.get() != 0;
+            ForwardableString cacheName = readString(buf);
 
-            String cacheName;
-            int hash = 0;
-
-            if (cached) {
-                if (buf.remaining() < 4)
-                    return false;
-
-                hash = buf.getInt();
-
-                cacheName = knownStrs.get(hash);
-
-                if (buf.remaining() < cacheStartRecordSize(0, true) - 1 - 4)
-                    return false;
-            }
-            else {
-                if (buf.remaining() < 4)
-                    return false;
-
-                int nameLen = buf.getInt();
-
-                if (buf.remaining() < cacheStartRecordSize(nameLen, false) - 1 - 4)
-                    return false;
-
-                cacheName = readString(buf, nameLen);
-            }
+            if (cacheName == null || buf.remaining() < readCacheStartRecordSize())
+                return false;
 
             int cacheId = buf.getInt();
 
+            forwardRead(cacheName);
+
             for (PerformanceStatisticsHandler hnd : curHnd)
-                hnd.cacheStart(nodeId, cacheId, cacheName);
+                hnd.cacheStart(nodeId, cacheId, cacheName.str);
 
             return true;
         }
@@ -524,8 +453,14 @@ else if (opType == PAGES_WRITE_THROTTLE) {
             throw new IgniteException("Unknown operation type id [typeId=" + opTypeByte + ']');
     }
 
-    /** Turns on forward read mode. */
-    private void forwardRead(int hash) throws IOException {
+    /**
+     * Enables forward read mode when  {@link ForwardableString#str} is null.
+     * @see ForwardableString
+     */
+    private void forwardRead(ForwardableString forwardableStr) throws IOException {
+        if (forwardableStr.str != null)
+            return;
+
         if (forwardRead != null)
             return;
 
@@ -543,7 +478,7 @@ private void forwardRead(int hash) throws IOException {
 
         curHnd = NOOP_HANDLER;
 
-        forwardRead = new ForwardRead(hash, curRecPos, nextRecPos, bufPos);
+        forwardRead = new ForwardRead(forwardableStr.hash, curRecPos, nextRecPos, bufPos);
     }
 
     /** Resolves performance statistics files. */
@@ -585,9 +520,31 @@ static List<File> resolveFiles(List<File> filesOrDirs) throws IOException {
         return null;
     }
 
-    /** Reads string from byte buffer. */
-    private String readString(ByteBuffer buf, int size) {
-        byte[] bytes = new byte[size];
+    /**
+     * Reads cacheable string from byte buffer.
+     *
+     * @return {@link ForwardableString} with result of reading or {@code null} in case of buffer underflow.
+     */
+    private ForwardableString readString(ByteBuffer buf) {
+        if (buf.remaining() < 1 + 4)
+            return null;
+
+        boolean cached = buf.get() != 0;
+
+        if (cached) {
+            int hash = buf.getInt();
+
+            String str = knownStrs.get(hash);
+
+            return new ForwardableString(str, hash);
+        }
+
+        int textLen = buf.getInt();
+
+        if (buf.remaining() < textLen)
+            return null;
+
+        byte[] bytes = new byte[textLen];
 
         buf.get(bytes);
 
@@ -598,32 +555,24 @@ private String readString(ByteBuffer buf, int size) {
         if (forwardRead != null && forwardRead.hash == str.hashCode())
             forwardRead.found = true;
 
-        return str;
+        return new ForwardableString(str, str.hashCode());
     }
 
     /**
-     * Reads cacheable string from byte buffer.
-     *
-     * @return String or {@code null} in case of buffer underflow.
+     * Result of reading string from buffer that may be cached.
+     * Call {@link #forwardRead(ForwardableString)} after reading the entire record to enable forward read mode.
      */
-    private String readCacheableString(ByteBuffer buf) {
-        if (buf.remaining() < 1 + 4)
-            return null;
+    private static class ForwardableString {
+        /** Can be {@code null} if the string is cached and there is no such {@link #hash} in {@link #knownStrs}. */
+        @Nullable final String str;
 
-        boolean cached = buf.get() != 0;
-
-        if (cached) {
-            int hash = buf.getInt();
-
-            return knownStrs.get(hash);
-        }
-        else {
-            int textLen = buf.getInt();
-
-            if (buf.remaining() < textLen)
-                return null;
+        /** */
+        final int hash;
 
-            return readString(buf, textLen);
+        /** */
+        ForwardableString(@Nullable String str, int hash) {
+            this.str = str;
+            this.hash = hash;
         }
     }
 

modules/core/src/main/java/org/apache/ignite/internal/processors/performancestatistics/FilePerformanceStatisticsWriter.java

@@ -511,7 +511,7 @@ private static File resolveStatisticsFile(GridKernalContext ctx) throws IgniteCh
     }
 
     /** Writes {@link UUID} to buffer. */
-    private static void writeUuid(ByteBuffer buf, UUID uuid) {
+    static void writeUuid(ByteBuffer buf, UUID uuid) {
         buf.putLong(uuid.getMostSignificantBits());
         buf.putLong(uuid.getLeastSignificantBits());
     }