Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(hubble): add docker-compose to start with server #522

Merged
merged 2 commits into from
Oct 8, 2023
Merged

doc(hubble): add docker-compose to start with server #522

merged 2 commits into from
Oct 8, 2023

Conversation

aroundabout
Copy link
Contributor

Purpose of the PR

  • update the way to quick start server with hubble

Main Changes

  • update the way to quick start server with hubble

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@github-actions github-actions bot added the hubble hugegraph-hubble label Sep 19, 2023
imbajin
imbajin reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the instrinstruction in root (enhance the desc)

image

hugegraph-hubble/README.md Outdated
- 8088:8088
```

Then we should follow the [hubble doc](https://hugegraph.apache.org/cn/docs/quickstart/hugegraph-hubble/#3%E5%B9%B3%E5%8F%B0%E4%BD%BF%E7%94%A8%E6%B5%81%E7%A8%8B) to create the graph.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use en doc link to avoid the long encode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

imbajin
imbajin reviewed Sep 19, 2023
View reviewed changes
hugegraph-hubble/README.md Outdated
```
version: '3'
services:
graph_hubble:
Copy link
Member

@imbajin imbajin Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graph_hubble seems a little confused? (use server?)

and shall we add the preload param here (comment it or not by default)

imbajin
imbajin approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simon824 simon824 merged commit d7733db into apache:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@simon824 simon824 simon824 approved these changes

@z7658329 z7658329 Awaiting requested review from z7658329

Assignees
No one assigned
Labels
hubble hugegraph-hubble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aroundabout @imbajin @simon824