Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the OpenTelemetry trace support #2477

Merged
merged 13 commits into from
Mar 15, 2024
Merged

Conversation

lynnbond
Copy link
Contributor

Purpose of the PR

  • close #xxx

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ci-cd Build or deploy feature New feature labels Mar 12, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (c09982b) to head (530fdf5).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2477      +/-   ##
============================================
- Coverage     66.34%   66.30%   -0.04%     
+ Complexity      829      827       -2     
============================================
  Files           511      511              
  Lines         42624    42624              
  Branches       5947     5947              
============================================
- Hits          28278    28262      -16     
- Misses        11541    11554      +13     
- Partials       2805     2808       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin requested a review from VGalaxies March 15, 2024 02:09
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 15, 2024
command: ["-config.file=/etc/tempo.yaml"]
volumes:
- ../conf/tempo.yaml:/etc/tempo.yaml
- ../data/tempo:/tmp/tempo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we(users) could modify the path as their wish

@imbajin imbajin merged commit 7b33574 into apache:master Mar 15, 2024
19 of 21 checks passed
VGalaxies added a commit that referenced this pull request Mar 15, 2024
TODO: we need enhance our shell experience
---------

Co-authored-by: imbajin <[email protected]>
Co-authored-by: VGalaxies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy feature New feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants