Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pd-store): added the OpenTelemetry trace support for pd-store #2479

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

VGalaxies
Copy link
Contributor

follow up #2477

usage (after running otel-collector):

./bin/start-hugegraph-pd.sh -y true
./bin/start-hugegraph-store.sh -y true
./bin/start-hugegraph.sh -y true

@VGalaxies VGalaxies added pd PD module store Store module labels Mar 15, 2024
@VGalaxies VGalaxies requested a review from imbajin March 15, 2024 13:01
@VGalaxies VGalaxies self-assigned this Mar 15, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature New feature labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pd-store@d56ad10). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             pd-store    #2479   +/-   ##
===========================================
  Coverage            ?   55.25%           
  Complexity          ?     1902           
===========================================
  Files               ?      718           
  Lines               ?    58320           
  Branches            ?     7489           
===========================================
  Hits                ?    32227           
  Misses              ?    22912           
  Partials            ?     3181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 16, 2024
@imbajin
Copy link
Member

imbajin commented Mar 16, 2024

Seems we could ignore the unrelated test error?

@VGalaxies
Copy link
Contributor Author

Seems we could ignore the unrelated test error?

Are you referring to the expected failure of the hstore core tests? It can be ignored for now.

@imbajin imbajin merged commit f34b528 into pd-store Mar 16, 2024
16 of 17 checks passed
@imbajin imbajin deleted the pd-store-ot branch March 16, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature lgtm This PR has been approved by a maintainer pd PD module size:L This PR changes 100-499 lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants