Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure serverless-workflow-examples are working properly #1860

Open
26 of 38 tasks
LuboTerifaj opened this issue Jan 29, 2024 · 7 comments
Open
26 of 38 tasks

Ensure serverless-workflow-examples are working properly #1860

LuboTerifaj opened this issue Jan 29, 2024 · 7 comments
Assignees

Comments

@LuboTerifaj
Copy link

LuboTerifaj commented Jan 29, 2024

Description

Some serverless-workflow-examples may not work properly.

Goal

Report individual issues for all examples that do not work properly.
Link all found issues in the comments.

Scope

Please mark the example below as checked once it is reviewed and all found issues are reported. Those issues don't have to be resolved as part of this issue.
The goal of this issue is to identify issues in examples. The found issues resolution is out of scope, although welcomed.

Examples to be checked

  • serverless-workflow-annotations-description
  • serverless-workflow-callback-events-over-http-quarkus
  • serverless-workflow-callback-quarkus
  • serverless-workflow-camel-routes
  • serverless-workflow-compensation-quarkus
  • serverless-workflow-consuming-events-over-http-quarkus
  • serverless-workflow-correlation-quarkus
  • serverless-workflow-custom-function-knative
  • serverless-workflow-custom-type
  • serverless-workflow-data-index-quarkus
  • serverless-workflow-data-index-persistence-addon-quarkus
  • serverless-workflow-error-quarkus
  • serverless-workflow-events-quarkus
  • serverless-workflow-expression-quarkus
  • serverless-workflow-foreach-quarkus
  • serverless-workflow-functions-events-quarkus
  • serverless-workflow-functions-quarkus
  • serverless-workflow-funqy
  • serverless-workflow-github-showcase
  • serverless-workflow-greeting-quarkus
  • serverless-workflow-greeting-rpc-quarkus
  • serverless-workflow-hello-world
  • serverless-workflow-loanbroker-showcase
  • serverless-workflow-newsletter-subscription
  • serverless-workflow-oauth2-orchestration-quarkus
  • serverless-workflow-openvino-quarkus
  • serverless-workflow-order-processing
  • serverless-workflow-parallel-execution
  • serverless-workflow-python-quarkus
  • serverless-workflow-qas-service-showcase
  • serverless-workflow-saga-quarkus
  • serverless-workflow-service-calls-quarkus
  • serverless-workflow-stock-profit
  • serverless-workflow-temperature-conversion
  • serverless-workflow-testing-with-rest-assured
  • serverless-workflow-timeouts-showcase-embedded
  • serverless-workflow-timeouts-showcase-extended
  • serverless-workflow-timeouts-showcase-operator-devprofile

Acceptance criteria

All issues are regarding examples are reported and linked to this issue.

Implementation ideas

No response

@LuboTerifaj LuboTerifaj self-assigned this Jan 29, 2024
@wmedvede
Copy link
Contributor

For the record, the serverless-workflow-timeouts-showcase-extended example was addressed here #1857

@nmirasch
Copy link
Contributor

nmirasch commented Feb 2, 2024

@LuboTerifaj, here #1863 there are some changes on the examples to avoid using the quay.io/kiegroup/kogito-runtime-jvm:latest, and changing the referenced image at the docker compose by the nightly one to see the latest changes. Even I applied the changes in the serverless-workflow-examples, I just focused my testing cases in mainly working with docker-compose:

  • serverless-workflow-callback-quarkus
  • serverless-workflow-data-index-persistence-addon-quarkus
  • serverless-workflow-data-index-quarkus

Let's see how it goes, once the pr is merged we can add the check to that ones (at least)

@nmirasch
Copy link
Contributor

nmirasch commented Feb 12, 2024

@LuboTerifaj here #1870 serverless-workflow-newsletter-subscription have been also updated and verified that is working properly

@LuboTerifaj LuboTerifaj moved this from 📋 Backlog to ⏳ In Progress in 🦉 KIE Podling Board Jun 11, 2024
@LuboTerifaj
Copy link
Author

I found the following issues during review of some examples above:

@LuboTerifaj
Copy link
Author

Hello @gmunozfe , I am reassigning the issue to you for checking the remaining examples. Please see the description of the issue to understand its goal. Should you have any questions, don't hesitate to reach out to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⏳ In Progress
Development

No branches or pull requests

4 participants