From db0c4bdcff8896d9e43ecec5a156d06429572106 Mon Sep 17 00:00:00 2001 From: jianrongzhang89 Date: Thu, 5 Sep 2024 21:24:44 -0700 Subject: [PATCH] [issue-368] knative integration with DataIndex and JobService: fix workflow deletion hanging issue --- controllers/profiles/common/constants/platform_services.go | 1 - controllers/sonataflow_controller.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/controllers/profiles/common/constants/platform_services.go b/controllers/profiles/common/constants/platform_services.go index 9ba7c4e6d..4416ed7d3 100644 --- a/controllers/profiles/common/constants/platform_services.go +++ b/controllers/profiles/common/constants/platform_services.go @@ -37,7 +37,6 @@ const ( JobServiceJobEventsPath = "/v2/jobs/events" JobServiceLeaderCheckExpirationInSeconds = "kogito.jobs-service.management.leader-check.expiration-in-seconds" DefaultJobServiceLeaderCheckExpirationInSeconds = "60" - JobServiceRequestEventsURL = "mp.messaging.outgoing.kogito-job-service-job-request-events.url" KogitoProcessInstancesEventsConnector = "mp.messaging.outgoing.kogito-processinstances-events.connector" KogitoProcessInstancesEventsMethod = "mp.messaging.outgoing.kogito-processinstances-events.method" diff --git a/controllers/sonataflow_controller.go b/controllers/sonataflow_controller.go index 3436cff0c..6cfde4a18 100644 --- a/controllers/sonataflow_controller.go +++ b/controllers/sonataflow_controller.go @@ -129,7 +129,7 @@ func (r *SonataFlowReconciler) setDefaults(workflow *operatorapi.SonataFlow) { func (r *SonataFlowReconciler) cleanupTriggers(ctx context.Context, workflow *operatorapi.SonataFlow) error { plf, _ := platform.GetActivePlatform(ctx, r.Client, workflow.Namespace) - if plf == nil || len(plf.Status.Triggers) == 0 { + if plf == nil || len(workflow.Status.Triggers) == 0 { return nil } avail, err := knative.GetKnativeAvailability(r.Config)